Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests refactoring #1307

Open
wants to merge 63 commits into
base: dev
Choose a base branch
from
Open

Integration tests refactoring #1307

wants to merge 63 commits into from

Conversation

dmytrotsko
Copy link
Contributor

Summary:

Refactored old tests. Changed test's base class.
Added new method to send requests to the DelphiTestBase class

Prerequisites:

  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

rzats and others added 30 commits September 19, 2023 15:32
@rzats
Remove usage of PHP alias in the Python client
e59aeac
@rzats
Post review tweaks
b5128f0
@melange396
removed 'api.php' from comments where not appropriate
c65095e
@rzats
Merge branch 'dev' into rzatserkovnyi/api-php-refactor
3d8b827
@rzats
Refactor?
05e2b84
@rzats
Add pypi changelog
6e7190f
@rzats
Extra test for compat endpoint
4513ced
@rzats
Use del
832b25c
@dmytrotsko
Added basic integration tests for all endpoints
d5363e3
@dmytrotsko
Added base class for tests. Added API keys tests
9d99885
@dmytrotsko
Added TESTING_MODE to the ci.yaml, removed from Makefile
544ba94
@dmytrotsko
Updated acquisition tests with missing api_key creation
9eed497
@dmytrotsko @melange396
Update src/server/_config.py
da2a6a6 
Comments fix

Co-authored-by: melange396 <[email protected]>
@dmytrotsko @melange396
Update integrations/server/test_delphi.py
3b6b652 
Remove unused lib

Co-authored-by: melange396 <[email protected]>
@dmytrotsko @melange396
Update integrations/server/test_meta.py
b134408 
Remove extra newline

Co-authored-by: melange396 <[email protected]>
@dmytrotsko
Requested changes from PR's comments
15177ac
@dmytrotsko
Moved test_meta_norostat to test_norostat.py
9e4a332
@dmytrotsko
Remove test_meta_norostat.py as this test was moved to test_norostat.py
80c355c
@dmytrotsko @melange396
Update integrations/server/test_api_keys.py
5e3210f 
Co-authored-by: melange396 <[email protected]>
@dmytrotsko @melange396
Update integrations/server/test_norostat.py
dca4c0b 
Co-authored-by: melange396 <[email protected]>
@dmytrotsko @melange396
Update src/common/integration_test_base_class.py
27f66a4 
Co-authored-by: melange396 <[email protected]>
@dmytrotsko @melange396
Update integrations/server/test_norostat.py
d9d83f3 
Co-authored-by: melange396 <[email protected]>
@rzats @dmytrotsko
Remove usage of PHP alias in the Python client
386c348
@rzats @dmytrotsko
Post review tweaks
591059c
@dmytrotsko
Adjusted tests to use new API url
66257b2
@dmytrotsko
Changed base test class, renamed class name
4259294
@dmytrotsko
Changed base class name. Replaced Epidata usage with local class object.
f1f9744
@dmytrotsko
Renamed test_utils.py to covidcast_test_base.py and moved it to src/c…
8538532 
…ommon.
@dmytrotsko
Replaced localSetUp with setUp in order to uselocalSetUp in covidcast…
e0c370d 
… tests
@dmytrotsko
Replaced base class to CovidcastTestBase, removed unnecessary code fr…
6fa0072 
…om setUp method. Removed few blank lines.
dmytrotsko and others added 20 commits October 2, 2023 17:07
@dmytrotsko
Removed epidata client auth set
236e87d
@dmytrotsko
Changed base class. Removed unnecessary code.
92fcefd
@dmytrotsko
Fix wrong import
105be04
@dmytrotsko
Replace unittest.TestCase with custom base class. Remove unnecessary …
7bdf683 
…code. Adjust test case's code.
@dmytrotsko
Final adjustments
987d990
@dmytrotsko
Fixed ght test
a2377f4
@melange396
revert to previous behavior, and mark deprecated ( not fully tested)
9eb559c
@melange396
also revert tests
3f5e1a6
@rzats
Merge latest dev changes
15e4987
@rzats
test_api_keys tweak
5f0b521
@rzats
Fix failing test
cd665bd
@rzats
More test tweaks
65d1587
@melange396
Merge pull request #1295 from cmu-delphi/revert_deprecate_async_epidata
1f9bf19 
revert and deprecate async_epidata (+ Remove usage of PHP alias in the Python client)
@melange396
changelog update
e701cb6
@melange396
changelog update (formatting)
fefc088
@rzats
Remove public_route
b527347
@dmytrotsko
Sync integration_tests with rzatserkovnyi/api-php-refactor
7e59806
@dmytrotsko
Removed unnecessary tests debugging options
c97adad
@dmytrotsko
Removed comment
3dfdea6
@dmytrotsko
Moved params to the top of the test case
1677629
@melange396 melange396 mentioned this pull request Oct 12, 2023
Closed
3 tasks
Base automatically changed from rzatserkovnyi/api-php-refactor to dev October 12, 2023 16:33
@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 5 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
2.8% 2.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

5 Security Hotspots

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melange396 melange396 Awaiting requested review from melange396

@rzats rzats Awaiting requested review from rzats

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmytrotsko @rzats @melange396