Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google Docs Meta Data #1501

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Update Google Docs Meta Data #1501

merged 3 commits into from
Jul 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 25, 2024

Updating Google Docs Meta Data

  • Adds "External Name" column to db_sources.csv
  • Adds "nssp" data source and a number of signals for it
  • Includes fix to restrict DataSource() construction to only applicable fields

@github-actions github-actions bot added the chore label Jul 25, 2024
@github-actions github-actions bot requested a review from melange396 July 25, 2024 15:24
@melange396 melange396 changed the base branch from signals_sync_action_fix to dev July 25, 2024 15:40
...as was done for DataSignal() in #1303 , and using the same ugly over-extended comprehension pattern
Copy link

sonarcloud bot commented Jul 25, 2024

@melange396 melange396 changed the base branch from dev to signals_sync_action_fix July 25, 2024 17:00
@melange396
Copy link
Collaborator

csv content changes look good to me!

Base automatically changed from signals_sync_action_fix to dev July 25, 2024 17:57
An error occurred while trying to automatically change base from signals_sync_action_fix to dev July 25, 2024 17:57
Copy link
Contributor

@dmytrotsko dmytrotsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@melange396 melange396 merged commit d9d024e into dev Jul 29, 2024
6 checks passed
@melange396 melange396 deleted the bot/update-docs branch July 29, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants