pub_covid_hosp_state_timeseries to use as_of parameter
#219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
requested review from
dshemetov,
brookslogan and
dsweber2
as code owners
dshemetov
approved these changes
Nov 28, 2023
| ) | ||
| } | ||
|
|
||
| if (sum(!is.null(issues), !is.null(as_of)) > 1) { |
There was a problem hiding this comment.
suggestion(non-blocking, separate issue): just learned about rlang::check_exclusive, definitely easier to read
There was a problem hiding this comment.
there's this snag though: r-lib/rlang#1647
There was a problem hiding this comment.
At the moment, the sum-!is.null approach is standard across endpoints, so will leave it as-is here.
Opened issue #222
Co-authored-by: Dmitry Shemetov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209
Note: the server code is designed to handle
as_ofandissues, but notlag.