-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
105 parameter tuning #131
Open
ChloeYou
wants to merge
26
commits into
dev
Choose a base branch
from
105-parameter-tuning
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
105 parameter tuning #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 105-parameter-tuning
dajmcdon
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test comment
Merge branch 'frosting' of https://github.com/cmu-delphi/epipredict into 105-parameter-tuning # Conflicts: # DESCRIPTION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a demo vignette to show how I approached cross validation and hyperparameter tuning, so it doesn't need to be merged into the main branch. The current Epipredict workflow doesn't seem to directly support CV and parameter tuning, good news is that they can still be achieved with a few extra lines of code. The biggest issue seems to come from the recipes step - the model doesn't recognize the new variables created in recipes and causes some issues with subsequent steps in CV. The way to work around it is it prep and bake the data before passing it into the workflow for CV & tuning.
@dajmcdon Would you be able to take a look when you're available? Let me know if you want to discuss more on it. Thank you!