Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slide_mean and slide_sum #367

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

slide_mean and slide_sum #367

wants to merge 2 commits into from

Conversation

dsweber2
Copy link
Contributor

@dsweber2 dsweber2 commented Aug 5, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

This is a continuation of #275 that adds the specific methods for step_epi_slide_mean and step_epi_slide_sum; step_epi_slide_opt would be similar, though hasn't yet been implemented. step_epi_slide should have a warning/dispatch to these methods, though at the moment step_epi_slide doesn't NA pad, while these do. Currently leaving this partially finished until we need the comparatively faster speeds of these methods.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dsweber2 dsweber2 requested a review from dajmcdon as a code owner August 5, 2024 15:53
@dsweber2 dsweber2 marked this pull request as draft August 13, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant