Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default slide values #387

Closed
wants to merge 4 commits into from
Closed

fix default slide values #387

wants to merge 4 commits into from

Conversation

dsweber2
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

The actual defaults for epi_slide for before and after are NULL, so defaulting to 0 here breaks in the case of e.g. weekly data. For an example, see the test.

@dajmcdon
Copy link
Contributor

@dsweber2 Can this be closed in light of #386 ?

@dsweber2
Copy link
Contributor Author

looks like it

@dsweber2
Copy link
Contributor Author

might be worth keeping to have a test of weekly, though probably easier to start from scratch

@dajmcdon
Copy link
Contributor

Agreed. Let's rebase this on dev after #386 (changes the args to step_epi_slide anyway), then add a test for weekly.

@dshemetov
Copy link
Contributor

This should raise an error if .window_size = NULL because epi_slide already does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants