Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update sliding vignette #416

Merged
merged 1 commit into from
Oct 28, 2024
Merged

doc: update sliding vignette #416

merged 1 commit into from
Oct 28, 2024

Conversation

dshemetov
Copy link
Contributor

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

Updates the sliding vignette, brings it out of articles to the dropdown, and renames it to backtesting. Lines the vignette up to follow along with the rewritten vignette in epiprocess, but instead use the arx_forecaster.

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

DESCRIPTION Outdated Show resolved Hide resolved
DEVELOPMENT.md Outdated Show resolved Hide resolved
pkgdown-watch.r Outdated Show resolved Hide resolved
vignettes/.gitignore Outdated Show resolved Hide resolved
vignettes/backtesting.Rmd Outdated Show resolved Hide resolved
vignettes/backtesting.Rmd Outdated Show resolved Hide resolved
vignettes/backtesting.Rmd Show resolved Hide resolved
vignettes/backtesting.Rmd Outdated Show resolved Hide resolved
vignettes/backtesting.Rmd Outdated Show resolved Hide resolved
inst/pkgdown-watch.r Outdated Show resolved Hide resolved
* rename to backtesting, simplify
* move out of articles and into dropdown
@dshemetov dshemetov merged commit e9f5924 into dev Oct 28, 2024
2 checks passed
@dshemetov dshemetov deleted the ds/vignettes branch October 28, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants