Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix population scaling with other_keys (+ allow single-quantile-level predictions) #418

Conversation

brookslogan
Copy link
Contributor

@brookslogan brookslogan commented Oct 24, 2024

Checklist

Please:

  • Make sure this PR is against "dev", not "main".
  • Request a review from one of the current epipredict main reviewers:
    dajmcdon.
  • Make sure to bump the version number in DESCRIPTION and NEWS.md.
    Always increment the patch version number (the third number), unless you are
    making a release PR from dev to main, in which case increment the minor
    version number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    0.7.2, then write your changes under the 0.8 heading).
  • Consider pinning the epiprocess version in the DESCRIPTION file if
    • You anticipate breaking changes in epiprocess soon
    • You want to co-develop features in epipredict and epiprocess

Change explanations for reviewer

  • testing on non-epi_df --> fixes for non-epi_df --> moving by default setting into prep or construction
  • write up explanation
  • update documentation
  • update NEWS.md
  • figure out if epiprocess dependency version range needs adjusted

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

Recent/current epiprocess versions silently ignore `extra_keys =`. Pending
epiprocess changes will soft-deprecate and route it to `other_keys =` instead,
plus add some stricter checks on `other_keys =`.
- Rename `extra_keys` -> `other_keys` when we are going to feed it into
  `other_keys =`.
- Remove some `<edf metadata>$other_keys %||% character()` hedges now that
  current epiprocess standardizes to character() not NULL and example `epi_df`
  objects have been updated to that standard.
@brookslogan brookslogan changed the base branch from dev to ndefries/epidatasets-migration October 24, 2024 18:05
@nmdefries nmdefries deleted the branch cmu-delphi:ndefries/epidatasets-migration October 28, 2024 21:37
@nmdefries nmdefries closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants