-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust epi_slide_opt
output naming; adjust epi_slide*
autogrouping; fix tidyselect issue
#564
Open
brookslogan
wants to merge
14
commits into
dev
Choose a base branch
from
lcb/epi_slide_opt-output-renaming
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brookslogan
force-pushed
the
lcb/epi_slide_opt-output-renaming
branch
4 times, most recently
from
November 8, 2024 19:35
7a8ec75
to
85503c1
Compare
brookslogan
force-pushed
the
lcb/epi_slide_opt-output-renaming
branch
5 times, most recently
from
November 12, 2024 02:18
1627870
to
e6f7264
Compare
|
brookslogan
force-pushed
the
lcb/epi_slide_opt-output-renaming
branch
from
November 12, 2024 19:55
e6f7264
to
6a22c4b
Compare
- BREAKING CHANGE: adjust default output column naming scheme, disallow overwriting columns.
brookslogan
force-pushed
the
lcb/epi_slide_opt-output-renaming
branch
2 times, most recently
from
November 12, 2024 20:59
882e960
to
9669773
Compare
brookslogan
force-pushed
the
lcb/epi_slide_opt-output-renaming
branch
from
November 12, 2024 22:42
fdc9ee7
to
79ed2f3
Compare
- Show naming options, including with multi-column selections when we have accommodating example data sets - Select away the pre-existing 7d aggregations in the example data set - Ungroup output
brookslogan
force-pushed
the
lcb/epi_slide_opt-output-renaming
branch
from
November 14, 2024 20:51
845f4c0
to
beb434c
Compare
brookslogan
force-pushed
the
lcb/epi_slide_opt-output-renaming
branch
from
November 14, 2024 21:29
45170b1
to
f9a8356
Compare
brookslogan
force-pushed
the
lcb/epi_slide_opt-output-renaming
branch
from
November 14, 2024 21:43
ed23df0
to
6d8bcf6
Compare
brookslogan
changed the title
Lcb/epi slide opt output renaming
Adjust Nov 14, 2024
epi_slide_opt
output naming; adjust epi_slide*
autogrouping; fix tidyselect bug
brookslogan
changed the title
Adjust
Adjust Nov 14, 2024
epi_slide_opt
output naming; adjust epi_slide*
autogrouping; fix tidyselect bugepi_slide_opt
output naming; adjust epi_slide*
autogrouping; fix tidyselect issue
We may later need it to make default args, in which case we should probably export to be less "magical".
@nmdefries sorry for all the noise here; I tried to implement just 1 time utility from #494 but forgot it actually relied on the concept of a "unit" time delta/step; fixed that up and added the unit time step helper. Think that's fixed now. Also fixed some CHECK issues. The core changes, and now these helpers, should hopefully be ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION
. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
.suffix
(and.prefix
?) arguments to slides #542.epi_slide_opt
work with!!varname
, maybe!!varnames
, maybe!!!varnames
#562