Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5.1 #118

Merged
merged 6 commits into from
May 28, 2024
Merged

2.5.1 #118

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6b5c442
Remove error message when PC4 answer is null.
sei-jvessella May 28, 2024
0778586
Do not add non-http(s) URLs to video freshness task.
sei-jvessella May 28, 2024
7853887
Clarify null answer log message.
sei-jvessella May 28, 2024
377286a
Clarify non-ISO log message.
sei-jvessella May 28, 2024
70f0be1
Exempt unsubmitted token text for museum answers.
sei-jvessella May 28, 2024
b878f86
Quiet misleading warning message when playing PC4.
sei-jvessella May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions gamebrain/gamedata/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,8 @@ async def video_freshness_task(cls):
video_urls = []
async with cls._lock:
for comm_event in cls._cache.comm_map.__root__.values():
video_urls.append(comm_event.videoURL)
if "http" in comm_event.videoURL:
video_urls.append(comm_event.videoURL)

next_refresh = cls._next_video_refresh

Expand Down Expand Up @@ -1039,18 +1040,23 @@ async def _handle_first_year_tasks(
question.answer
)
except TypeError:
logging.error(
"Question "
f"{task_id} in PC4 game had a null answer."
)
# The answer will be null if there's been no submission
# yet. In that case, don't complain.
if question.answer is not None:
logging.error(
"Question "
f"{task_id} in PC4 game had a bad answer type: "
f"{question.answer}."
)
except ValueError:
# This means the answer was a non-ISO-format string.
# It's no problem if the question is marked correct.
logging.error(
"Question "
f"{task_id} in PC4 game had an answer "
"not in ISO format."
)
if question.answer != "You did not earn a token for this part":
logging.error(
"Question "
f"{task_id} in PC4 game had an answer "
f"not in ISO format: {question.answer}"
)
else:
if team_data.pc4_handling_cllctn6 < last_failed_audit:
send_cllctn6_failure = True
Expand Down Expand Up @@ -1684,10 +1690,12 @@ async def _get_team_unlocked_missions(
score_data["baseSolveValue"] = mission_score_data.base_solve_value
score_data["bonusRemaining"] = mission_score_data.bonus_remaining
elif team_id:
logging.warning(
f"Team {team_id} had no score data for "
f"mission {mission.missionID}"
)
# PC4 scores require special handling.
if not team_data.ship.gamespaceData.isPC4Workspace:
logging.warning(
f"Team {team_id} had no score data for "
f"mission {mission.missionID}"
)

if team_id:
teams_solved = await cls._get_mission_completion_in_team_session(
Expand Down
Loading