Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ci #1

Merged
merged 14 commits into from
Jan 9, 2025
Merged

Feature/ci #1

merged 14 commits into from
Jan 9, 2025

Conversation

sei-secheverria
Copy link

Addresses CI setup in project. CI will still fail for now since there are no unit tests, but that should be fixed shortly. This PR specifically:

  • Adds a Github Actions CI config to add a CI workflow
  • Adds make commands to simplify running the different linting checks and formatting commands
  • Added type hint checking to all of the above
  • Added new optional group for qa dependencies
  • Added type hints and some casts where needed
  • Fixed type issue where Flag attributes were being abused as both strings and as the later compiled regex patterns, by storing both things separately

@sei-kpitstick sei-kpitstick merged commit dda6271 into main Jan 9, 2025
4 checks passed
@sei-kpitstick sei-kpitstick deleted the feature/ci branch January 9, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants