[Implementation] (Proposal 2) Add Benchmark Pipeline #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipankardas011
force-pushed
the
iterate/121
branch
2 times, most recently
from
b0a97ab to
6b08f69
Compare
rossf7
reviewed
Nov 19, 2024
There was a problem hiding this comment.
@dipankardas011 Looks good just a few minor comments. We should also update proposal 2 since this changes the design.
rossf7
reviewed
Nov 21, 2024
There was a problem hiding this comment.
@dipankardas011 Some more renaming is needed due to the param name change.
Please check if any more renaming is required and then I think this is good to go.
dipankardas011
commented
Nov 27, 2024
It will give us a alternative route to use kubernetes manifests for the benchmark jobs instead of reusing github workflow. With this we are trying to use the manifest location in github or any public facing endpoint from where we can get them Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
Signed-off-by: Dipankar Das <[email protected]>
it will help us to exactly point which commit this file belongs to and avoids updates to the file in the specific branch and we accidentally use wrong or maliciously crafted manifest Signed-off-by: Dipankar Das <[email protected]>
dipankardas011
force-pushed
the
iterate/121
branch
from
b7b97ba to
35d0d7d
Compare
|
@dipankardas011 could you rebase with EDIT: sorry, just saw that you did that already and it's green! 👍 I hadn't refreshed my page 🙈 |
nikimanoledaki
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
kind/feature
What this PR does / why we need it:
It will give us a alternative route to use kubernetes manifests for the benchmark jobs instead of reusing github workflow.
With this we are trying to use the manifest location in github or any public facing endpoint from where we can get them
Which issue(s) this PR fixes:
Addresses part of #121
Special notes for your reviewer (optional):
Created this for finding alternative route for the current proposal 2 impl
Refer: #124, #121 (comment)