skeleton for proposal3 #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
rossf7
reviewed
Jan 10, 2025
| // other metrics from prometheus | ||
| } | ||
| return metrics, nil | ||
| } |
There was a problem hiding this comment.
@AntonioDiTuri Thank you for creating this PR. It was v helpful when I was looking at dagger in #154
For now could we focus on collecting the metrics and pause looking at deployment?
If we use dagger we could run the pipeline as a pod in the cluster and access prometheus via its service https://docs.dagger.io/integrations/kubernetes
@ChrisChinchilla would be great to get your thoughts on that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal 3 skeleton if helps to lay the foundation of this tracking story: #145