Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable i18n with pt-br(Portuguese) for website #737

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

juliafmorgado
Copy link

This PR makes Portuguese available in the language selection menu.

Translated Pages for Review:

  • website/config.toml
  • website/i18n/pt-br.toml

Additional Translations (as per #612):

  • website/content/pt-br/contribute/_index.md
  • website/content/pt-br/search.md
  • website/content/pt-br/wgs/_index.md
  • website/content/pt-br/wgs/app-development/_index.md
  • website/content/pt-br/wgs/artifacts/_index.md

This is the first step to complete #736

Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for tag-app-delivery ready!

Name Link
🔨 Latest commit 33f1376
🔍 Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/66cde7bb3109b100082ccf21
😎 Deploy Preview https://deploy-preview-737--tag-app-delivery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@abangser
Copy link
Collaborator

Hey @juliafmorgado thanks so much for taking the time on this PR!

We will need to do a code/design review, but also need at least one more native speaker review. Do you have anyone in mind that can do the review? If not we can ask around and try to find someone!

@juliafmorgado
Copy link
Author

juliafmorgado commented Aug 22, 2024

Hey @abangser, @julialamenza mentioned she can review it. Do you need additional reviewers?

Thanks!

@abangser
Copy link
Collaborator

Nope, that'll do! I'll try and do the technical review this weekend so that we don't block you 🙌

Copy link
Collaborator

@abangser abangser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a technical point of view. One thing to call out is that I wasn't sure about the Brazilian qualification on Portuguese but the CNCF glossary is also pr-br.

Signed-off-by: Julia Furst Morgado <[email protected]>
@juliafmorgado
Copy link
Author

Thanks @abangser! Regarding the language code, I followed what was written in the Kubernetes website documentation https://kubernetes.io/docs/contribute/localization/#find-your-two-letter-language-code

@abangser
Copy link
Collaborator

Hey @juliafmorgado just wanted to touch base around the review for this PR. I believe we are waiting for a native speaker review. Is that your understanding? Anything I can do to help?

Copy link

@julialamenza julialamenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a Native speaker LGTM

Copy link
Collaborator

@abangser abangser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done a pass through both the code and the deployed app and they look good. The only thing that may be unnecessary is the blog page as that doesn't have any translations on it, but I also don't think it harms anything.

We will need a TAG lead/TL to merge this (you can see them assigned in the top right as well as message them via the #tag-app-delivery channel in slack).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Related to TAG website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants