Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLOG] Reducing your environmental impact with the Linkerd service mesh #234

Merged
merged 9 commits into from
Oct 6, 2023

Conversation

CathPag
Copy link
Contributor

@CathPag CathPag commented Oct 3, 2023

Contributed blog post for sustainability week. Fixes #222

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for tag-env-sustainability ready!

Name Link
🔨 Latest commit df9fdb7
🔍 Latest deploy log https://app.netlify.com/sites/tag-env-sustainability/deploys/65205105ad2fb00008529d73
😎 Deploy Preview https://deploy-preview-234--tag-env-sustainability.netlify.app/blog/2023-reducing-env-impact-with-linkerd
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@leonardpahlke
Copy link
Member

@catblade PTAL, since you mentioned some changes in the issue #222

Copy link
Member

@leonardpahlke leonardpahlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CathPag we need to add a header with some meta information to the markdown file. I suggested adding one 🙌

…he-linkerd-service-mesh.md

Co-authored-by: Leonard Vincent Simon Pahlke <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
CathPag and others added 2 commits October 6, 2023 09:33
…he-linkerd-service-mesh.md

Co-authored-by: Leonard Vincent Simon Pahlke <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
Copy link
Contributor

@catblade catblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is REALLY nice. Thank you. Minor nits-take them or leave them. I have no ego here. :-) But LGTM even without the changes.

CathPag and others added 4 commits October 6, 2023 14:24
…he-linkerd-service-mesh.md

Co-authored-by: Marlow Weston <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
…he-linkerd-service-mesh.md

Co-authored-by: Marlow Weston <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
…he-linkerd-service-mesh.md

Co-authored-by: Marlow Weston <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
…he-linkerd-service-mesh.md

Co-authored-by: Marlow Weston <[email protected]>
Signed-off-by: Catherine Paganini <[email protected]>
@CathPag
Copy link
Contributor Author

CathPag commented Oct 6, 2023

Suggestions look good, thanks everyone! 🙌

@catblade
Copy link
Contributor

catblade commented Oct 6, 2023

We should squash and merge. It's LGTM for me. @leonardpahlke and @TheFoxAtWork (don't remember if you have to approve blog posts too) can you review please?

@leonardpahlke leonardpahlke merged commit b0d1f36 into cncf:main Oct 6, 2023
7 of 8 checks passed
@leonardpahlke
Copy link
Member

We do not require a review from our TOC Liaisons if the blog post is a community guest blog.

@catblade
Copy link
Contributor

catblade commented Oct 7, 2023

Great work, @CathPag !

@CathPag
Copy link
Contributor Author

CathPag commented Oct 9, 2023

Thanks, everyone!!

@catblade
Copy link
Contributor

catblade commented Oct 9, 2023

@CathPag who would I work with to get a section in the landscape doc on linkerd?

@CathPag
Copy link
Contributor Author

CathPag commented Oct 10, 2023

We can take care of it, but we'll need some time. We have a product launch next week and then there's a lot of KubeCon prep. But I'll add that to our to-do list. Thanks for pointing me to the doc. And good luck with Sustainability Week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BLOG] Reducing your environmental impact with the Linkerd service mesh
3 participants