[BLOG] Towards Optimized Microservices Performance & Sustainability via Istio, Kepler and Smart Scheduling #242
Conversation
✅ Deploy Preview for tag-env-sustainability ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jiangphcn
force-pushed
the
kubecon-istio-kepler
branch
4 times, most recently
from
ffb461a to
df79ab3
Compare
There was a problem hiding this comment.
Thanks for opening the PR @jiangphcn 👍 🙌
format review comments:
...-Optimized-Microservices-Performance-Sustainability-via-Istio-Kepler-and-Smart-Scheduling.md
Outdated
Show resolved
Hide resolved
...-Optimized-Microservices-Performance-Sustainability-via-Istio-Kepler-and-Smart-Scheduling.md
Outdated
Show resolved
Hide resolved
...-Optimized-Microservices-Performance-Sustainability-via-Istio-Kepler-and-Smart-Scheduling.md
Outdated
Show resolved
Hide resolved
...-Optimized-Microservices-Performance-Sustainability-via-Istio-Kepler-and-Smart-Scheduling.md
Outdated
Show resolved
Hide resolved
|
cc @catblade |
jiangphcn
force-pushed
the
kubecon-istio-kepler
branch
from
df79ab3 to
4cb6f55
Compare
|
Thanks @leonardpahlke for review and giving valuable comments on this PR. I already addressed them and pushed new commit 4cb6f55. In the meanwhile, I addressed the markdownlint issue in this PR. Just FYI: there are still some issues in |
|
@jiangphcn thanks - I we don't need to fix these Lint findings in this PR; I will open another one for that, thanks for pointing it out. cc @catblade (if you find time for a blog review) |
|
Will do tomorrow. Thanks for the ping! |
There was a problem hiding this comment.
@jiangphcn thanks a lot for your contribution!
I have added a few suggestions, mostly related to image references
Markdown errors related to the Linkerd blog post have been resolved in a different PR so the build state should look much better once you sync your branch with main branch.
...-Optimized-Microservices-Performance-Sustainability-via-Istio-Kepler-and-Smart-Scheduling.md
Outdated
Show resolved
Hide resolved
...-Optimized-Microservices-Performance-Sustainability-via-Istio-Kepler-and-Smart-Scheduling.md
Outdated
Show resolved
Hide resolved
...-Optimized-Microservices-Performance-Sustainability-via-Istio-Kepler-and-Smart-Scheduling.md
Outdated
Show resolved
Hide resolved
jiangphcn
force-pushed
the
kubecon-istio-kepler
branch
from
4cb6f55 to
17f7b40
Compare
…ia Istio, Kepler and Smart Scheduling (cncf#241) Signed-off-by: Peng Hui Jiang <[email protected]>
jiangphcn
force-pushed
the
kubecon-istio-kepler
branch
from
17f7b40 to
c6528a9
Compare
|
@guidemetothemoon, thanks a lot for your comments and suggestion. I already addressed them in latest commit. Also i fetched the latest from upstream, and don't see markdown lint issue any more. |
|
@leonardpahlke @guidemetothemoon thanks for review and merge. I checked the published blog, and it looks that images are not displayed correctly. Could you please help? |
|
@jiangphcn images were placed in the wrong directory, they needed to be placed in the static/images folder. The issue will be fixed once #250 is merged. |
|
thank you @guidemetothemoon |
|
Fix Merged |
The related issue is
#241
@rootfs