Merge pull request #282 from co-cddo/bug/DEV_319-fix-n+1-query

Load the related objects eagerly.
co-cddo · Sep 20, 2024 · 2f8bf0e · 2f8bf0e
2 parents 3222d30 + 0d5a4cc
commit 2f8bf0e
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/request_a_govuk_domain/request/admin/model_admins.py b/request_a_govuk_domain/request/admin/model_admins.py
@@ -172,6 +172,15 @@ class ReviewAdmin(SimpleHistoryAdmin, FileDownloadMixin, admin.ModelAdmin):
     model = Review
     form = ReviewForm
     change_form_template = "admin/review_change_form.html"
+    list_select_related = [
+        "application",
+        "application__owner",
+        "application__last_updated_by",
+        "application__registrar_person",
+        "application__registrant_person",
+        "application__registrant_org",
+        "application__registrar_org",
+    ]
 
     list_display = (
         "get_reference",
@@ -516,6 +525,14 @@ class ApplicationAdmin(
         django.db.models.fields.files.FileField: {"widget": CustomAdminFileWidget},
     }
     actions = ["export", "archive"]
+    list_select_related = [
+        "owner",
+        "last_updated_by",
+        "registrar_person",
+        "registrant_person",
+        "registrant_org",
+        "registrar_org",
+    ]
 
     def download_file_view(self, request, object_id, field_name):
         application = self.model.objects.get(id=object_id)