Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Session timeout non JS version. #294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Session timeout non JS version. #294

wants to merge 1 commit into from

Conversation

jinnashravan
Copy link
Contributor

  1. After 20 minutes cookie session timesout and shows a session-ended page.

@jinnashravan
Session timeout non JS version.
71619a0 
1. After 20 minutes cookie session timesout and shows a session-ended page.
maxf
maxf requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@maxf maxf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a more detailed commit message, including why we're doing this.

Also, have you thought about any way to write tests for this?

request_a_govuk_domain/request/forms.py


class SessionEndedForm(forms.Form):
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a form here. Just a page with a link should do.

request_a_govuk_domain/request/templates/registrar_details.html
@@ -13,6 +13,21 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use consistent indentation across the file? I think other templates use 2 characters.

request_a_govuk_domain/request/templates/session_ended.html


{% block content %}
<div class="govuk-grid-row">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation should be 2 chars

request_a_govuk_domain/settings.py
@@ -259,8 +259,8 @@
CSRF_FAILURE_VIEW = "request_a_govuk_domain.request.views.csrf_failure_view"
SESSION_COOKIE_SECURE = True

# Set session (end-user or admin) to expire in 24 hours
SESSION_COOKIE_AGE = 24 * 60 * 60
# Set session end-user to expire in 20 minutes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't apply to admins? Originally the session duration was limited for admins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxf maxf maxf requested changes

@dhvander dhvander Awaiting requested review from dhvander

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinnashravan @maxf