Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full happy path 1 #38

Merged
merged 6 commits into from
Mar 8, 2024
Merged

Full happy path 1 #38

merged 6 commits into from
Mar 8, 2024

Conversation

maxf
Copy link
Contributor

@maxf maxf commented Mar 7, 2024

No description provided.

maxf added 2 commits March 7, 2024 18:26
Required 4 new pages and lots of modifications to tie them all together
They don't work in all situations
@maxf maxf requested review from prakash-gds and jinnashravan March 7, 2024 18:34
else:
return redirect('confirm')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have the Registrant page in place, we should call that page rather than confirm page here.

@maxf maxf requested a review from jinnashravan March 8, 2024 11:45
Copy link
Contributor

@jinnashravan jinnashravan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jinnashravan jinnashravan merged commit 081f65d into main Mar 8, 2024
1 check passed
@jinnashravan jinnashravan deleted the almost-full-journey branch March 8, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants