Add models #40
Merged
Add models #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakash-gds
reviewed
Mar 8, 2024
prakash-gds
reviewed
Mar 8, 2024
Models to reflect the current thinking on the data required to make a decision on an application. In the Review model we use the simple-history package to track changes made to the review fields.
And the references to it in the confirm page view. Comment out the assignment of the registration data to stop flake8 complaining.
So we only have registrant types recorded in one place.
prakash-gds
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add models, as required by the current version of the Mural.
This adds django-phonenumber-field, however the main functionality (validation) has to be added to the forms rather than the models.
It also adds simple-history and includes it in the Review model, however further config will be needed to determine what is logged on change.
request/views.pyhas been changed to remove a reference to the now-removed model and the reference to that model removed from the confirm page view.