Run cypress as a github action when pushing #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxf
force-pushed
the
github-action-cypress
branch
8 times, most recently
from
d5176b0 to
8c4ce30
Compare
Because another button might be on the page (when the user is correcting their previous answer)
That page is at the end of the process when the session has been recorded and deleted
maxf
force-pushed
the
github-action-cypress
branch
from
8c4ce30 to
0f7ed8c
Compare
Given that keys are assigned internally, there's not much point checking them. Better would be that we check they reflect a valid journey, but that should only be considered when the possible paths are finalised.
prakash-gds
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal of this PR is to make running the end-to-end tests a github action on push.
But since the tests were broken, this PR also fixes them.
In the process it fixes the confirmation page (which is not a form) and the session checking middleware.