Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add init management cmds #64

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Add init management cmds #64

merged 3 commits into from
Mar 13, 2024

Conversation

jimnarey
Copy link
Contributor

@jimnarey jimnarey commented Mar 13, 2024

This removes the reviewer group seed data and creates the group using a Django management command. This avoids hardcoded references to object pks in the seed data, requiring frequent refreshing of the fixture.

There is a test for the management command, so run the test(s) in GitHub Actions.

Because this adds permissions with reference to the model
classes it's less brittle than using seed data.
@jimnarey jimnarey force-pushed the add-init-management-cmds branch from e544e2c to 72aef42 Compare March 13, 2024 18:09
Also remove a redundant branch in the GitHub Actions.
@jimnarey jimnarey force-pushed the add-init-management-cmds branch from 72aef42 to 1768a03 Compare March 13, 2024 18:14
@jimnarey jimnarey merged commit 185acc9 into main Mar 13, 2024
1 check passed
@jimnarey jimnarey deleted the add-init-management-cmds branch April 18, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants