Fix gitmate's complain #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed broken ci, and avoids gitmate's complain
|
What is the problem that you are trying to solve ? |
|
There is a problem with gitmate as it is checking the test python file, see pr #18 |
|
Also the badge in readme is showing error, I guess my pr will solve it. |
Closed
|
#18 is red because a maintainer flagged it for needing improvement, not a build failure. https://travis-ci.org/coala/coala-emacs/builds/255744435 did fail. That was #17 |
jayvdb
reviewed
Nov 7, 2017
|
No, this is a difficult problem, and you need to finish the newcomer process. |
This was referenced Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes broken ci, and avoids gitmate's complain
I think .coafile is only needed for functioning code in this repo, so I excluded python's config and injected it manually each time ci is running.
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!