Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re_botcmd_fullmatch: Add re_botcmd_fullmatch #403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Re_botcmd_fullmatch: Add re_botcmd_fullmatch #403

wants to merge 1 commit into from

Conversation

meetmangukiya
Copy link
Member

Closes #402

Reviewers Checklist

  • Appropriate logging is done.
  • Appropriate error responses.
  • Handle every possible exception.
  • Make sure there is a docstring in the command functions. Hint: Lookout for
    botcmd and re_botcmd decorators.
  • See that 100% coverage is there.
  • See to it that mocking is not done where it is not necessary.

gitmate-bot
gitmate-bot reviewed Nov 27, 2017
View reviewed changes
plugins/re_botcmd_fullmatch.py Outdated
"""
Triggers on plugin activation

You should delete it if you're not using it to override any default behaviour
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E501 line too long (85 > 80 characters)

Origin: PycodestyleBear (E501), Section: all.autopep8.

gitmate-bot
gitmate-bot reviewed Nov 27, 2017
View reviewed changes
plugins/re_botcmd_fullmatch.py Outdated
"""
Triggers on plugin activation

You should delete it if you're not using it to override any default behaviour
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than allowed. (85 > 80)

Origin: LineLengthBear, Section: all.linelength.

gitmate-bot
gitmate-bot reviewed Nov 27, 2017
View reviewed changes
plugins/re_botcmd_fullmatch.py Outdated

@botcmd
def check_regexes(self, msg, args)
if hasattr(self.bot_config, 'RE_BOTCMD_FULLMATCH_IGNORES'):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E113 unexpected indentation

Origin: PycodestyleBear (E113), Section: all.autopep8.

gitmate-bot
gitmate-bot reviewed Nov 27, 2017
View reviewed changes
plugins/re_botcmd_fullmatch.py Outdated

@botcmd
def check_regexes(self, msg, args)
if hasattr(self.bot_config, 'RE_BOTCMD_FULLMATCH_IGNORES'):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E113 unexpected indentation

Origin: PycodestyleBear (E113), Section: all.autopep8.

gitmate-bot
gitmate-bot reviewed Nov 27, 2017
View reviewed changes
plugins/re_botcmd_fullmatch.py Outdated

@botcmd
def check_regexes(self, msg, args)
if hasattr(self.bot_config, 'RE_BOTCMD_FULLMATCH_IGNORES'):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E113 unexpected indentation

Origin: PycodestyleBear (E113), Section: all.autopep8.

@supergr35
Copy link
Member

test coverage ;)

jayvdb
jayvdb requested changes Aug 13, 2018
View reviewed changes
plugins/re_botcmd_fullmatch.py
from errbot import BotPlugin, botcmd


class Re_botcmd_fullmatch(BotPlugin):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rather than a plugin, we should not use re_botcmd , and instead use a better decorator which does this check and then defers to re_botcmd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitmate-bot gitmate-bot gitmate-bot left review comments

@jayvdb jayvdb jayvdb requested changes

Assignees

@meetmangukiya meetmangukiya

Labels
enhancement process/wip size/XS status/STALE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@meetmangukiya @supergr35 @jayvdb @gitmate-bot @co-robo