Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .gitkeep files #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove .gitkeep files #63

wants to merge 1 commit into from

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Jun 13, 2018

Unnecessary empty directories should not be needed.

Closes #57

@jayvdb
Remove .gitkeep files
9989ff4 
Unnecessary empty directories should not be needed.

Closes coala#57
@jayvdb jayvdb added the blocked label Jun 13, 2018
@jayvdb
Copy link
Member Author

jayvdb commented Jun 13, 2018

This could have strange effects; best to wait until after coding phase 1 merges are done.

@jayvdb jayvdb requested a review from bekicot June 13, 2018 08:44
@jayvdb
Copy link
Member Author

jayvdb commented Jun 13, 2018

Note that one of the .gitkeep files is being removed in https://github.com/coala/git-task-list/pull/33/files#diff-6158d15d9911d78785c74b0105180875

That shouldnt happen, as those files are not related to GraphQL.

@jayvdb jayvdb requested a review from andrewda June 14, 2018 02:22
andrewda
andrewda approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@andrewda andrewda left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it doesn't break anything (which I doubt it would)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewda andrewda andrewda approved these changes

@bekicot bekicot Awaiting requested review from bekicot

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayvdb @andrewda