-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No LLM scenario #482
No LLM scenario #482
Conversation
✅ Deploy Preview for fluxdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for fluxsocial-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
conversation = allConversations.find((c) => | ||
subgroupLinks.find((link) => link.data.source === c.baseExpression) | ||
); | ||
subgroups = [subgroup]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could be done in more concise way with one prolog query...
|
||
resolve(); | ||
resolve(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a pretty long function with several blocks with different concerns. It would help to extract meaningful functions...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for instance having one function to collect all the needed data like the subgroup and previous messages..
} | ||
} | ||
} | ||
if (!conversation) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think of this function as like a method on conversation - so maybe at least pass in the conversation as paremeter so we don't have to deal with this case here too.
LLM processing if new items (messages, etc.) gets signalled through an "empty" SemanticRelationship on that item. Agents without LLM configured won't create any link. There is new UI to show to users which items are being processed and if there are any items that nobody processes. Users with an LLM config can take on the processing of those items by clicking a button.