Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No LLM scenario #482

Merged
merged 20 commits into from
Jan 14, 2025
Merged

No LLM scenario #482

merged 20 commits into from
Jan 14, 2025

Conversation

jhweir
Copy link
Contributor

@jhweir jhweir commented Dec 19, 2024

LLM processing if new items (messages, etc.) gets signalled through an "empty" SemanticRelationship on that item. Agents without LLM configured won't create any link. There is new UI to show to users which items are being processed and if there are any items that nobody processes. Users with an LLM config can take on the processing of those items by clicking a button.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for fluxdocs ready!

Name Link
🔨 Latest commit ac6daa9
🔍 Latest deploy log https://app.netlify.com/sites/fluxdocs/deploys/67864ea89a6d2b000865c841
😎 Deploy Preview https://deploy-preview-482--fluxdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for fluxsocial-dev ready!

Name Link
🔨 Latest commit ac6daa9
🔍 Latest deploy log https://app.netlify.com/sites/fluxsocial-dev/deploys/67864ea8b04c3600088218f2
😎 Deploy Preview https://deploy-preview-482--fluxsocial-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

conversation = allConversations.find((c) =>
subgroupLinks.find((link) => link.data.source === c.baseExpression)
);
subgroups = [subgroup];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be done in more concise way with one prolog query...


resolve();
resolve();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty long function with several blocks with different concerns. It would help to extract meaningful functions...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for instance having one function to collect all the needed data like the subgroup and previous messages..

}
}
}
if (!conversation) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think of this function as like a method on conversation - so maybe at least pass in the conversation as paremeter so we don't have to deal with this case here too.

@lucksus lucksus merged commit 7dd82c5 into dev Jan 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants