Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add App deployment configuration #360

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

SchoolGuy
Copy link
Member

@SchoolGuy SchoolGuy commented Nov 9, 2024

Fixes #76

This is a follow-up for #207

  • Add deployment configuration file
  • Add logged in server to NavBar above version
  • Modify login to allow selection of urls from deployment configuration file
  • Default project is Cobbler so updated README to include --project is required for ng generate

Edit: I updated to rxjs7 with this PR.

@SchoolGuy SchoolGuy added this to the V0.0.1 milestone Nov 9, 2024
@github-actions github-actions bot added the Frontend Project cobbler-frontend label Nov 9, 2024
@SchoolGuy
Copy link
Member Author

SchoolGuy commented Nov 9, 2024

This doesn't work as intended at the moment because the APP_INITALIZATION token would slow down the application which we don't want because the user potentially has to wait to see the page because the connection is slow. Getting this to work with async code didn't turn out to be a five-minute job. Investigating tomorrow.

@SchoolGuy SchoolGuy force-pushed the feature/add-server-side-config branch from fdff505 to 5589515 Compare November 10, 2024 09:11
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 10, 2024
@SchoolGuy
Copy link
Member Author

SchoolGuy commented Nov 10, 2024

Now this works fully async and even hides the input if only one entry is specified. The rest of the requirements from the issue are also implemented. As such the input shows when either no config is present or more than one server is given in the configuration file. The input is proposing options via the autocomplete functionality.

@SchoolGuy SchoolGuy marked this pull request as ready for review November 10, 2024 09:14
@SchoolGuy SchoolGuy merged commit 0a7f27b into main Nov 10, 2024
16 checks passed
@SchoolGuy SchoolGuy deleted the feature/add-server-side-config branch November 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Frontend Project cobbler-frontend
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Login-Page: Server field should be optional
2 participants