-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Re-enable Windows for testing #31
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
It appears that we are running into golang/go#51269 |
After a bit of investigation, it appears that we are using the |
f6552cb
to
e826e29
Compare
e826e29
to
0c2dd36
Compare
0c2dd36
to
f0f471b
Compare
I will extend the scope of this PR to also remove go-utils from the dependencies of the project so we can have our own implementation of an HTTPClient. This allows us then to use buffered responses for multiple requests and responses per-test. |
Working on this PR showed that the creation of objects is not possible since we are using the embedded item structs due to the method |
Okay Windows likes use now. Let's get back to fixing the skipped tests. |
d4f4f68
to
5e5ecd7
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Signed-off-by: Enno Gotthold <[email protected]>
Signed-off-by: Enno Gotthold <[email protected]>
70dfd46
to
a774da6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just have some minor things I want to clarify, otherwise LGTM. One general comment I want to make though is that the DeleteItemRecursive tests seem kind of useless to me since we only test them in the false case where the behaviour is the same as in the non recurisve function
Signed-off-by: Enno Gotthold <[email protected]>
This change was done server side with 3.3.0.
This is a helper method that doesn't perform an XML-RPC call which verifies if a given interface is the magic "<<inherit>>" or not.
This commit also fixes the Windows test issues and fixes the implementation of "updateCobblerFields" to make the test pass.
a774da6
to
0ff47d4
Compare
Fixes #2
The scope of this PR was expanded due to details that appeared during the actual bugfix. This PR now contains changes for the following things:
enable_gpxe
was renamed toenable_ipxe
IsValueInherit
The code in this PR was not validated against a running Cobbler instance.