Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: Add return value for GetStatus #77

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

SchoolGuy
Copy link
Member

Fixes #76

This adds support for the return value of both normal and text mode of the get_status XML-RPC API endpoints.

@SchoolGuy SchoolGuy requested a review from a team November 14, 2024 09:06
@SchoolGuy SchoolGuy force-pushed the feature/get-status-output branch from 6df65ac to 5e729dc Compare November 14, 2024 09:10

This comment was marked as duplicate.

Copy link

codacy-production bot commented Nov 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.18% (target: -1.00%) 66.67% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3c5c0c5) 3268 1939 59.33%
Head commit (e3d8034) 3312 (+44) 1971 (+32) 59.51% (+0.18%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#77) 48 32 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@tiltingpenguin tiltingpenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, otherwise lgtm

cobblerclient.go Outdated Show resolved Hide resolved
@SchoolGuy SchoolGuy force-pushed the feature/get-status-output branch from 5e729dc to e3d8034 Compare November 14, 2024 09:20
@SchoolGuy SchoolGuy merged commit c7438d5 into main Nov 14, 2024
21 checks passed
@SchoolGuy SchoolGuy deleted the feature/get-status-output branch November 14, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support get_status endpoint
2 participants