Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testmap: rhel-9-6 enablement #6919

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

martinpitt
Copy link
Member

First round: throw everything against the wall and see what sticks.

@martinpitt
Copy link
Member Author

OK, so vdo kmod is once again MIA, that's a recurring issue #4545. I'll re-add the naughty.

@@ -83,7 +83,6 @@ def contexts(image: str, *scenarios: Iterable[str], repo: str | None = None) ->
],
'_manual': [
'centos-9-bootc',
'rhel-9-5',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional? Everywhere else you remove 9-6.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is intentional, yes. We've traditionally not tested starter-kit on rhel, but I'd like to keep the latest rhel-9-Y in manual. I.e. read this as "move manual from 9-5 to 9-6". Sorry for the confusion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright!

@martinpitt martinpitt requested review from mvollmer and removed request for mvollmer September 26, 2024 10:17
The issue is back in RHEL 9.6.

This reverts commit 06dc929.

Adjust the pattern a bit for current cockpit testlib.
@martinpitt
Copy link
Member Author

Wait, what? That's the vdo naughty I just re-added.. But the new testlib (webdriver-bidi) slightly changed the error message. I adjusted the naughties.

Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinpitt martinpitt merged commit 03d722f into cockpit-project:main Sep 26, 2024
13 checks passed
@martinpitt martinpitt deleted the enable-r96 branch September 26, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants