Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Update Cockpit lib to 35090b743b6b4536fc9c09cd9644c1c3 #875

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Jelle van der Waa (9):
base1: correct typeof invocation
lib: correctly check if rows are empty
lib: cockpit: rename location to location-utils
lib: cockpit: split location into a separate class
metrics: don't divide a number with a string
lib: correct DbusClient.proxy() typing
lib: add DbusClient.watch() in TypeScript typing
lib: allow cockpit.location to be modified
test: typecheck: output stats of TS errors for JavaScript files

Marius Vollmer (11):
lib: Adapt TypeaheadSelect and MultiTypeaheadSelect to key navigation changes
lib: Add useOn hook, for our own EventEmitter
lib: Import SimpleSelect template from PatternFly
lib: Correct TypeScript errors in SimpleSelect
lib: Make our changes to SimpleSelect
lib: Use SimpleSelect for ServerTime
lib: Use SimpleSelect for ShutdownModal
lib: Use SimpleSelect for FirewalldRequest
lib: Don't apply double spacing fix globally to all dropdowns
lib: Explicitly use white background color for MenuToggle
test: Remove Browser.select_PF_deprecated

Martin Pitt (10):
build: Move to es2021
networkmanager, systemd: Fix boolean or operators
lib: cockpit.channel.wait() takes an optional callback
playground, shell: Add type assertions for external dict lookups
shell: Robustify final_countdown
shell: Don't add string and number
test: Avoid parentheses for tuples in subscripts
test: Annotate js_error_codes type
Use raw strings with re functions
Don't mark used function arguments as dummy

@github-actions github-actions bot added the bot label Dec 12, 2024
@github-actions github-actions bot changed the title [no-test] Makefile: Update Cockpit lib to 35090b743b6b4536fc9c09cd9644c1c3 Makefile: Update Cockpit lib to 35090b743b6b4536fc9c09cd9644c1c3 Dec 12, 2024
@github-actions github-actions bot force-pushed the cockpit-lib-update-cockpit-lib-20241212-025957 branch from 6945890 to f1a2907 Compare December 12, 2024 03:00
@martinpitt
Copy link
Member

IMHO we should hold that back a little -- this is the same spacing regression in TypeaheadSelect that we introduced in cockpit-project/cockpit#21356 . There should be a follow-up first to fix this.

src/app.scss Outdated
@@ -189,6 +189,12 @@
margin-inline-end: 0;
}

// Fix the double-spacing issue for other dropdowns
// https://github.com/patternfly/patternfly/issues/6632
.pf-v5-c-menu-toggle__controls:last-child > .pf-v5-c-menu-toggle__toggle-icon {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make regular MenuToggles look "wrong", see cockpit-project/cockpit#21356 (comment). I think it would be better to make this apply only to the MenuToggles where you explicitly want this, like the bookmarks dropdown.

@jelly jelly force-pushed the cockpit-lib-update-cockpit-lib-20241212-025957 branch from cc43e7b to ae15df6 Compare December 13, 2024 12:09
@jelly jelly requested a review from mvollmer December 13, 2024 13:06
Copy link
Member

@mvollmer mvollmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinpitt martinpitt merged commit ee1818c into main Dec 13, 2024
20 of 26 checks passed
@martinpitt martinpitt deleted the cockpit-lib-update-cockpit-lib-20241212-025957 branch December 13, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants