-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile: Update Cockpit lib to 35090b743b6b4536fc9c09cd9644c1c3 #875
Makefile: Update Cockpit lib to 35090b743b6b4536fc9c09cd9644c1c3 #875
Conversation
6945890
to
f1a2907
Compare
IMHO we should hold that back a little -- this is the same spacing regression in TypeaheadSelect that we introduced in cockpit-project/cockpit#21356 . There should be a follow-up first to fix this. |
src/app.scss
Outdated
@@ -189,6 +189,12 @@ | |||
margin-inline-end: 0; | |||
} | |||
|
|||
// Fix the double-spacing issue for other dropdowns | |||
// https://github.com/patternfly/patternfly/issues/6632 | |||
.pf-v5-c-menu-toggle__controls:last-child > .pf-v5-c-menu-toggle__toggle-icon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will make regular MenuToggle
s look "wrong", see cockpit-project/cockpit#21356 (comment). I think it would be better to make this apply only to the MenuToggles where you explicitly want this, like the bookmarks dropdown.
cc43e7b
to
ae15df6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Jelle van der Waa (9):
base1: correct typeof invocation
lib: correctly check if rows are empty
lib: cockpit: rename location to location-utils
lib: cockpit: split location into a separate class
metrics: don't divide a number with a string
lib: correct DbusClient.proxy() typing
lib: add DbusClient.watch() in TypeScript typing
lib: allow cockpit.location to be modified
test: typecheck: output stats of TS errors for JavaScript files
Marius Vollmer (11):
lib: Adapt TypeaheadSelect and MultiTypeaheadSelect to key navigation changes
lib: Add useOn hook, for our own EventEmitter
lib: Import SimpleSelect template from PatternFly
lib: Correct TypeScript errors in SimpleSelect
lib: Make our changes to SimpleSelect
lib: Use SimpleSelect for ServerTime
lib: Use SimpleSelect for ShutdownModal
lib: Use SimpleSelect for FirewalldRequest
lib: Don't apply double spacing fix globally to all dropdowns
lib: Explicitly use white background color for MenuToggle
test: Remove Browser.select_PF_deprecated
Martin Pitt (10):
build: Move to es2021
networkmanager, systemd: Fix boolean or operators
lib: cockpit.channel.wait() takes an optional callback
playground, shell: Add type assertions for external dict lookups
shell: Robustify final_countdown
shell: Don't add string and number
test: Avoid parentheses for tuples in subscripts
test: Annotate js_error_codes type
Use raw strings with
re
functionsDon't mark used function arguments as dummy