Skip to content

Commit

Permalink
bidi test run
Browse files Browse the repository at this point in the history
  • Loading branch information
martinpitt committed Aug 12, 2024
1 parent 6830292 commit a9a1b64
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ COCKPIT_REPO_FILES = \
$(NULL)

COCKPIT_REPO_URL = https://github.com/cockpit-project/cockpit.git
COCKPIT_REPO_COMMIT = b5a98be3e0601b45cd8a557cde1c80b896a903fb # 322 + 19 commits
COCKPIT_REPO_COMMIT = 7e655ef0bea1a1a63e199fcead3ab1c5ba8f77df # https://github.com/cockpit-project/cockpit/pull/20832

$(COCKPIT_REPO_FILES): $(COCKPIT_REPO_STAMP)
COCKPIT_REPO_TREE = '$(strip $(COCKPIT_REPO_COMMIT))^{tree}'
Expand Down
2 changes: 1 addition & 1 deletion test/check-machines-networks
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class TestMachinesNetworks(machineslib.VirtualMachinesCase):
b.click(".pf-v5-c-card .pf-v5-c-card__header button:contains(Network)")

# HACK: Firefox 112 on RHEL 8 does not have `:has` yet, so for now use JavaScript to obtain the elements parent sibling.
b.inject_js("""
b.eval_js("""
ph_input_form_helper_text = function(id) {
return document.getElementById(id).parentElement.parentElement.querySelector(".pf-v5-c-helper-text__item.pf-m-error").textContent
Expand Down
4 changes: 2 additions & 2 deletions test/machineslib.py
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ def stop_all():
self.allow_journal_messages(r".* couldn't get all properties of org.freedesktop.NetworkManager.Device at /org/freedesktop/NetworkManager/Devices/\d+: Timeout was reached")

# avoid error noise about resources getting cleaned up
self.addCleanup(lambda: not self.browser.cdp.valid or self.browser.logout())
self.addCleanup(lambda: not self.browser.valid or self.browser.logout())

# noVNC warns about this for non-TLS connections; for RHEL downstream testing
self.allow_browser_errors("noVNC requires a secure context")
Expand Down Expand Up @@ -501,7 +501,7 @@ def downloadVmsArtifacts(self):

def tearDown(self):
b = self.browser
if b.cdp.valid and b.is_present("#button.alert-link.more-button"):
if b.valid and b.is_present("#button.alert-link.more-button"):
b.click("button.alert-link.more-button")

if self.getError():
Expand Down

0 comments on commit a9a1b64

Please sign in to comment.