Skip to content

Commit

Permalink
test fixes
Browse files Browse the repository at this point in the history
`b.click()` was using old image tag right after it was changed.

https://cockpit-logs.us-east-1.linodeobjects.com/pull-1821-1c12b895-20240819-093316-fedora-39/log.html#13-2

Test checks if a warning is displayed therefore create button should
be disabled.

https://cockpit-logs.us-east-1.linodeobjects.com/pull-1821-bfa093ee-20240819-082934-debian-testing/log.html#10-2
  • Loading branch information
tomasmatus committed Aug 19, 2024
1 parent 25503bc commit 5b29b73
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/check-application
Original file line number Diff line number Diff line change
Expand Up @@ -1174,7 +1174,7 @@ class TestApplication(testlib.MachineCase):
second_tag = "localhost/copybox:latest"
self.execute(False, f"podman tag localhost:5000/my-busybox {second_tag}")
# expand details
b.click("#containers-images tr:contains('my-busybox') td.pf-v5-c-table__toggle button")
b.click(f"#containers-images tr:contains('{second_tag}') td.pf-v5-c-table__toggle button")
b.wait_in_text("#containers-images tbody.pf-m-expanded tr .image-details", second_tag)
dialog1.deleteImage(True, another=second_tag)

Expand Down Expand Up @@ -2434,7 +2434,7 @@ class TestApplication(testlib.MachineCase):
def testCreateContainerValidation(self):
def validateField(groupSelector, value, errorMessage, resetValue=""):
b.set_input_text(f"{groupSelector} input", value)
b.wait_visible(".pf-v5-c-modal-box__footer #create-image-create-run-btn:not(:disabled)")
b.wait_visible(".pf-v5-c-modal-box__footer #create-image-create-run-btn:disabled")
b.wait_in_text(f"{groupSelector} .pf-v5-c-helper-text__item-text", errorMessage)
b.wait_visible(".pf-v5-c-modal-box__footer #create-image-create-run-btn[aria-disabled=true]")
# Reset to acceptable value and verify the validation message is not present
Expand Down

0 comments on commit 5b29b73

Please sign in to comment.