Bump the patternfly group with 6 updates #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
github-actions
bot
changed the title
allisonkarlitskaya
force-pushed
the
dependabot/npm_and_yarn/patternfly-f0d83b27e1
branch
from
64f664e
to
f596691
Compare
|
This feels like a PF regression -- there shouldn't be a reason for the minus buttons to be disabled? |
|
@dependabot recreate |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/patternfly-f0d83b27e1
branch
from
f596691
to
e381129
Compare
allisonkarlitskaya
force-pushed
the
dependabot/npm_and_yarn/patternfly-f0d83b27e1
branch
from
e381129
to
ba75764
Compare
jelly
force-pushed
the
dependabot/npm_and_yarn/patternfly-f0d83b27e1
branch
from
ba75764
to
76415ba
Compare
It's not a regression, PF's numberinput has become stricter and no longer accepts a string as a valid input for numberinput. Our state was messed up anyway as clicking the plus icon made the state a number and manually entering a string. |
Bumps the patternfly group with 6 updates: | Package | From | To | | --- | --- | --- | | [@patternfly/patternfly](https://github.com/patternfly/patternfly) | `5.3.1` | `5.4.0` | | [@patternfly/react-core](https://github.com/patternfly/patternfly-react) | `5.3.4` | `5.4.0` | | [@patternfly/react-icons](https://github.com/patternfly/patternfly-react) | `5.3.2` | `5.4.0` | | @patternfly/react-styles | `5.3.1` | `5.4.0` | | [@patternfly/react-table](https://github.com/patternfly/patternfly-react) | `5.3.4` | `5.4.0` | | [@patternfly/react-tokens](https://github.com/patternfly/patternfly-react) | `5.3.1` | `5.4.0` | Updates `@patternfly/patternfly` from 5.3.1 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly/releases) - [Changelog](https://github.com/patternfly/patternfly/blob/main/release.config.js) - [Commits](patternfly/patternfly@patch-v5.3.1...v5.4.0) Updates `@patternfly/react-core` from 5.3.4 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) Updates `@patternfly/react-icons` from 5.3.2 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) Updates `@patternfly/react-styles` from 5.3.1 to 5.4.0 Updates `@patternfly/react-table` from 5.3.4 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) Updates `@patternfly/react-tokens` from 5.3.1 to 5.4.0 - [Release notes](https://github.com/patternfly/patternfly-react/releases) - [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected]) --- updated-dependencies: - dependency-name: "@patternfly/patternfly" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-core" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-icons" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-styles" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-table" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly - dependency-name: "@patternfly/react-tokens" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: patternfly ... PatternFly's NumberInput has become stricter with the value's it accepts, it now does not accept a string as a valid value. This was a bug in podman as we had an inconsistent state which was either a string or number. Signed-off-by: dependabot[bot] <[email protected]>
jelly
force-pushed
the
dependabot/npm_and_yarn/patternfly-f0d83b27e1
branch
from
76415ba
to
d43d3fd
Compare
cockpituous
reviewed
Sep 2, 2024
| @@ -327,11 +327,20 @@ export class ImageRunModal extends React.Component { | |||
| } | |||
|
|
|||
| onPlusOne(key) { | |||
| this.setState(state => ({ [key]: parseInt(state[key]) + 1 })); | |||
| this.setState(state => ({ [key]: parseFloat(state[key]) + 1 })); | |||
There was a problem hiding this comment.
This added line is not executed by any test.
Comment on lines
+340
to
+341
| if (isNaN(value) || value < minimum) { | ||
| value = minimum; |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
| @@ -1125,7 +1134,7 @@ export class ImageRunModal extends React.Component { | |||
| plusBtnAriaLabel={_("Increase retries")} | |||
| onMinus={() => this.onMinusOne('healthcheck_retries')} | |||
| onPlus={() => this.onPlusOne('healthcheck_retries')} | |||
| onChange={ev => this.onValueChanged('healthcheck_retries', parseInt(ev.target.value) < 0 ? 0 : ev.target.value)} /> | |||
| onChange={ev => this.onNumberValue('healthcheck_retries', ev.target.value)} /> | |||
There was a problem hiding this comment.
This added line is not executed by any test.
|
CentOS 10 has different failures and unrelated:
|
martinpitt
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the patternfly group with 6 updates:
5.3.15.4.05.3.45.4.05.3.25.4.05.3.15.4.05.3.45.4.05.3.15.4.0Updates
@patternfly/patternflyfrom 5.3.1 to 5.4.0Release notes
Sourced from
@patternfly/patternfly's releases.... (truncated)
Commits
f75001aUpdate issue templatesa9e2a7aUpdate issue templatesc0c2559Update and rename PF6_alpha_bug_request.md to PF6_beta_bug_request.md (#6935)fec6266chore(deps): update dependency@patternfly/documentation-frameworkto v5.16.1...1550c08chore(deps): update dependency@patternfly/documentation-frameworkto v5.16.1...ca9b9e6fix(InlineEdit): updated example to match React (#6877)d5ee3d9chore(build): corepack use [email protected] (#6872)50182bechore(deps): update dependency@patternfly/react-code-editorto v5.3.4 (#6859)aad6f30fix(form): support label addl info in horizontal form (#6853)baa5f63chore(deps): update dependency@patternfly/react-tableto v5.3.4 (#6861)Updates
@patternfly/react-corefrom 5.3.4 to 5.4.0Commits
3ef073achore(release): releasing packages [ci skip]7a25febchore: Update promote.sh to promote to npm.494143dchore: Update promote.sh with dry run5836008Revert "chore(release): Update promote.sh"5937183chore(release): Update promote.sh701ccd9Revert "chore(release): releasing packages [ci skip]"48c08cbchore(release): releasing packages [ci skip]a76ba5echore(release): releasing packages [ci skip]279c54ffix(Table): remove blank scope in empty deprecated table headers (#10875)7b64b05Update issue templatesUpdates
@patternfly/react-iconsfrom 5.3.2 to 5.4.0Commits
3ef073achore(release): releasing packages [ci skip]7a25febchore: Update promote.sh to promote to npm.494143dchore: Update promote.sh with dry run5836008Revert "chore(release): Update promote.sh"5937183chore(release): Update promote.sh701ccd9Revert "chore(release): releasing packages [ci skip]"48c08cbchore(release): releasing packages [ci skip]a76ba5echore(release): releasing packages [ci skip]279c54ffix(Table): remove blank scope in empty deprecated table headers (#10875)7b64b05Update issue templatesUpdates
@patternfly/react-stylesfrom 5.3.1 to 5.4.0Updates
@patternfly/react-tablefrom 5.3.4 to 5.4.0Commits
3ef073achore(release): releasing packages [ci skip]7a25febchore: Update promote.sh to promote to npm.494143dchore: Update promote.sh with dry run5836008Revert "chore(release): Update promote.sh"5937183chore(release): Update promote.sh701ccd9Revert "chore(release): releasing packages [ci skip]"48c08cbchore(release): releasing packages [ci skip]a76ba5echore(release): releasing packages [ci skip]279c54ffix(Table): remove blank scope in empty deprecated table headers (#10875)7b64b05Update issue templatesUpdates
@patternfly/react-tokensfrom 5.3.1 to 5.4.0Commits
3ef073achore(release): releasing packages [ci skip]7a25febchore: Update promote.sh to promote to npm.494143dchore: Update promote.sh with dry run5836008Revert "chore(release): Update promote.sh"5937183chore(release): Update promote.sh701ccd9Revert "chore(release): releasing packages [ci skip]"48c08cbchore(release): releasing packages [ci skip]a76ba5echore(release): releasing packages [ci skip]279c54ffix(Table): remove blank scope in empty deprecated table headers (#10875)7b64b05Update issue templatesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions