Fix irritating Enter key behaviour in container creation dialog #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrett
reviewed
Sep 26, 2024
martinpitt
force-pushed
the
select-enter
branch
from
d1b0491
to
e34f08e
Compare
mvollmer
previously approved these changes
Sep 26, 2024
| @@ -744,7 +744,7 @@ export class ImageRunModal extends React.Component { | |||
| ); | |||
|
|
|||
| const defaultBody = ( | |||
| <Form> | |||
| <Form onKeyDown={e => e.key === 'Enter' && e.preventDefault()}> | |||
There was a problem hiding this comment.
I think this calls for a comment.
There was a problem hiding this comment.
OK! Right, it's better as a comment than only just in the commit message. Added.
Pressing "Enter" in the dialog on any active form element (such as the search input or the checkboxes) previously bubbled up to the Form, which then activated the first popover help. This is unexpected and very irritating especially when using the search input. Just ignore the Enter key to fix that, similar to what the image search modal already does. See cockpit-project#1821 (comment)
martinpitt
force-pushed
the
select-enter
branch
from
e34f08e
to
8a1015b
Compare
mvollmer
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing "Enter" in the dialog on any active form element (such as the search input or the checkboxes) previously bubbled up to the Form, which then activated the first popover help. This is unexpected and very irritating especially when using the search input.
Just ignore the Enter key to fix that, similar to what the image search modal already does.
See #1821 (comment)