test: Wait for image search to be over in CreateContainer tests #1885
Conversation
mvollmer
force-pushed
the
dbg-create-container
branch
from
d74e025
to
fe9f185
Compare
mvollmer
force-pushed
the
dbg-create-container
branch
from
fe9f185
to
9bbb626
Compare
test/check-application
Outdated
| b.wait_in_text(".pf-v5-c-select__menu-list", "No images found") | ||
| b.click('button.pf-v5-c-toggle-group__button:contains("Local")') |
There was a problem hiding this comment.
I don't remember much of the history here, but switching to the "Local" filter is also useful coverage -- that seems to have gone now?
Could you do both, first wait for the "All registries" view to update, and then switch to Local and ensure that this works as well?
Unless of course we cover this somewhere else.
There was a problem hiding this comment.
Could you do both, first wait for the "All registries" view to update, and then switch to Local and ensure that this works as well?
Yes, let's do this.
There was a problem hiding this comment.
I don't remember much of the history here, but switching to the "Local" filter is also useful coverage -- that seems to have gone now?
I remember you made these changes when we introduced BiDi, but could only find https://github.com/cockpit-project/cockpit-podman/pull/1834/files#diff-e86755442bc7d21f0414014b3c356b54d6650e8ed9bffcc4f5858d1154df80e1R1801
There was a problem hiding this comment.
Ah, there are two instances of this pattern. I'll change the second one as well.
martinpitt
changed the title
mvollmer
force-pushed
the
dbg-create-container
branch
2 times, most recently
from
4e99a71
to
c4b718a
Compare
For example, one test was typing into the image name input and then immmediately proceeded to select an image from the dropdown. The selected image would already be in the dropdown from the start and thus it would be selected without waiting for the search to reveal it. The actual search would only start 300ms later and would at that point reset the image selection. If the test wasn't already done with the dialog at that point, the "Create button" would then be disabled. Let's just wait for the searching to be done before continuing, by observing unmatched images disappear from the list.
mvollmer
force-pushed
the
dbg-create-container
branch
from
c4b718a
to
fd6212f
Compare
|
Looks pretty good now. TestApplication.testHealthcheckUser on ubuntu-2204 flakes, but that's for another day/PR, I'd say. |
No description provided.