add instructions to enable kdump on microos systems #21182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lunarequest OK! Looks sensible. We don't run tests on MicroOS, so I trust you tested this manually. This is currently "draft", so please move to "ready to review" as appropriate. Thanks! |
|
Yep, tested this manually. Will move to ready for review when I can confirm the ansible instructions work as well |
Lunarequest
force-pushed
the
kdump-microos
branch
from
2743b66
to
b114379
Compare
cockpituous
reviewed
Nov 11, 2024
Comment on lines
46
to
47
| if (name?.includes('MicroOS')) { | ||
| setActiveTab("shell"); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test.
Comment on lines
86
to
82
| if (name?.includes('MicroOS')) { | ||
| return ( | ||
| <Modal isOpen={show} className="automation-script-modal" |
There was a problem hiding this comment.
These 3 added lines are not executed by any test.
Comment on lines
+93
to
+92
| <Tabs activeKey={active_tab} onSelect={handleSelect}> | ||
| <Tab eventKey="shell" title={_("Shell script")}> | ||
| <TextArea resizeOrientation='vertical' readOnlyVariant="default" defaultValue={shell.trim()} /> | ||
| </Tab> | ||
| </Tabs> | ||
| </Modal> |
There was a problem hiding this comment.
These 6 added lines are not executed by any test.
martinpitt
requested changes
Nov 11, 2024
Lunarequest
force-pushed
the
kdump-microos
branch
from
b114379
to
6b88f1e
Compare
…ible play on microos
Lunarequest
force-pushed
the
kdump-microos
branch
from
6b88f1e
to
e918a40
Compare
|
the failed tests seem to be unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on SLE/Opensuse microos, we use
transactional-updateto automatically set the required kernel arguments like Fedora. I need to confirm how we want to enable this on system via ansible. on its own this is safe to merge.