-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: Support headers with TypeaheadSelect #21183
base: main
Are you sure you want to change the base?
lib: Support headers with TypeaheadSelect #21183
Conversation
866b34b
to
5f5a440
Compare
a94ee95
to
018531b
Compare
018531b
to
5b6e088
Compare
ccbfbe7
to
ca76a3f
Compare
0ba70a1
to
79104d7
Compare
79104d7
to
16d2e4f
Compare
@garrett, I need your design input for how the headers should look. PF5 headers look like this: |
edd2893
to
eccba0c
Compare
@@ -320,7 +344,7 @@ export const TypeaheadSelectBase: React.FunctionComponent<TypeaheadSelectProps> | |||
|
|||
openMenu(); | |||
|
|||
if (filteredSelections.every((option) => option.isDisabled)) { | |||
if (filteredSelections.every(ignore)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added line is not executed by any test.
eccba0c
to
308138d
Compare
Yes, that's how PF5 headers look.
|
This PR implements its own headers, and doesn't use the PF group headers. (For technical reasons, the typeahead template is much easier to adapt to special entries in a flat list (the headers) than to dealing with a recursive structure (PFs select groups)). So the question is, how should the headers look? We can make them look identical to PF5, or easily improve upon the looks, if we want.
It's in the "Development Playground", sub-page "React Patterns": https://host:9090/playground/react-patterns |
I have styled the headers like PF menu groups: