Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Support headers with TypeaheadSelect #21183

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mvollmer
Copy link
Member

@mvollmer mvollmer commented Oct 29, 2024

I have styled the headers like PF menu groups:

image

@mvollmer mvollmer force-pushed the lib-typeahead-select-groups branch 2 times, most recently from 866b34b to 5f5a440 Compare October 29, 2024 12:15
@mvollmer mvollmer added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Oct 31, 2024
@mvollmer mvollmer force-pushed the lib-typeahead-select-groups branch 3 times, most recently from a94ee95 to 018531b Compare October 31, 2024 13:15
test/verify/check-lib-typeahead Fixed Show fixed Hide fixed
test/verify/check-lib-typeahead Fixed Show fixed Hide fixed
test/verify/check-lib-typeahead Fixed Show fixed Hide fixed
test/verify/check-lib-typeahead Fixed Show fixed Hide fixed
test/verify/check-lib-typeahead Fixed Show fixed Hide fixed
test/verify/check-lib-typeahead Fixed Show fixed Hide fixed
test/verify/check-lib-typeahead Fixed Show fixed Hide fixed
test/verify/check-lib-typeahead Fixed Show fixed Hide fixed
@mvollmer mvollmer force-pushed the lib-typeahead-select-groups branch 3 times, most recently from ccbfbe7 to ca76a3f Compare November 12, 2024 10:13
test/verify/check-lib Fixed Show fixed Hide fixed
@mvollmer mvollmer force-pushed the lib-typeahead-select-groups branch 2 times, most recently from 0ba70a1 to 79104d7 Compare November 12, 2024 12:27
@mvollmer mvollmer removed the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Nov 12, 2024
@mvollmer
Copy link
Member Author

@garrett, I need your design input for how the headers should look.

PF5 headers look like this:

image

@mvollmer mvollmer marked this pull request as ready for review November 12, 2024 13:40
@mvollmer mvollmer force-pushed the lib-typeahead-select-groups branch 5 times, most recently from edd2893 to eccba0c Compare November 13, 2024 09:01
@@ -320,7 +344,7 @@ export const TypeaheadSelectBase: React.FunctionComponent<TypeaheadSelectProps>

openMenu();

if (filteredSelections.every((option) => option.isDisabled)) {
if (filteredSelections.every(ignore)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This added line is not executed by any test.

@mvollmer mvollmer added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Nov 13, 2024
@mvollmer mvollmer added no-test For doc/workflow changes, or experiments which don't need a full CI run, and removed no-test For doc/workflow changes, or experiments which don't need a full CI run, labels Nov 13, 2024
@garrett
Copy link
Member

garrett commented Nov 13, 2024

@garrett, I need your design input for how the headers should look.

PF5 headers look like this:

Yes, that's how PF5 headers look.

  1. What are you looking for specifically? I'm not sure what you're asking.
  2. How would I check this out to verify that it looks like PF5? (Like, which page, modal, widget?) I've poked around after building the branch and it's not clear what I should be looking at.

@mvollmer
Copy link
Member Author

mvollmer commented Nov 15, 2024

@garrett, I need your design input for how the headers should look.
PF5 headers look like this:

Yes, that's how PF5 headers look.

  1. What are you looking for specifically? I'm not sure what you're asking.

This PR implements its own headers, and doesn't use the PF group headers. (For technical reasons, the typeahead template is much easier to adapt to special entries in a flat list (the headers) than to dealing with a recursive structure (PFs select groups)).

So the question is, how should the headers look? We can make them look identical to PF5, or easily improve upon the looks, if we want.

  1. How would I check this out to verify that it looks like PF5? (Like, which page, modal, widget?) I've poked around after building the branch and it's not clear what I should be looking at.

It's in the "Development Playground", sub-page "React Patterns": https://host:9090/playground/react-patterns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants