Split s3 server certificate out of tasks secrets #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasks containers don't need, and therefore should not have, the local minio S3 server certificate. Our ci-secrets.git repo already moved the S3 certificate out of `tasks/` into the top level `s3-server/` directory. Adjust the deployment scripts and integration test accordingly.
4 tasks
|
I deployed this to production, and the image server on rhos-01-1 works fine. The cert is also gone from cockpit-tasks* containers. |
|
@allisonkarlitskaya gentle review ping? |
allisonkarlitskaya
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks containers don't need, and therefore should not have, the local minio S3 server certificate.
Our ci-secrets.git repo already moved the S3 certificate out of
tasks/into the top levels3-server/directory. Adjust the deployment scripts and integration test accordingly.