Apply CRL patches #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow setting a set of errnos rather than just a particular errno or a random one from the entire set. Update the cookbook for random faults to exclude any errnos passed via extra arguments. My objective here is to be able to exclude a specific errno from random injection. The Go runtime gets confused by EAGAINs, which cause it to epoll_wait on the file descriptor. I'd like to exclude EAGAIN from the set of injected errors for my use case.
The CockroachDB test suite currently makes use of charybdefs-nemesis to induce artificial delays into the filesystem to simulate disk stalls. Currently, the delay duration is fixed at 50ms. This precludes testing of faults that last indefinitely. Change the format of the `--delay` command to take a duration, in microseconds, allowing for faults of a longer duration.
nicktrav
force-pushed
the
nickt.crl-patches
branch
from
093371a
to
cfa2134
Compare
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow specifying a set of errnos to select from.
Taken from scylladb#24.
Allow setting a set of errnos rather than just a particular errno or a
random one from the entire set. Update the cookbook for random faults to
exclude any errnos passed via extra arguments.
My objective here is to be able to exclude a specific errno from
random injection. The Go runtime gets confused by EAGAINs, which cause
it to epoll_wait on the file descriptor. I'd like to exclude EAGAIN from
the set of injected errors for my use case.
cookbook: allow for setting --delay duration
The CockroachDB test suite currently makes use of charybdefs-nemesis to
induce artificial delays into the filesystem to simulate disk stalls.
Currently, the delay duration is fixed at 50ms. This precludes testing
of faults that last indefinitely.
Change the format of the
--delaycommand to take a duration, inmicroseconds, allowing for faults of a longer duration.