Skip to content

Commit

Permalink
Merge pull request #137793 from cockroachdb/blathers/backport-release…
Browse files Browse the repository at this point in the history
…-24.3-137744

release-24.3: sql: allow CLOSE CURSOR in read-only txns
  • Loading branch information
yuzefovich authored Dec 24, 2024
2 parents f6a521e + 2957caf commit c96e4a1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion pkg/sql/logictest/testdata/logic_test/txn
Original file line number Diff line number Diff line change
Expand Up @@ -1520,13 +1520,16 @@ SET SESSION AUTHORIZATION DEFAULT
statement ok
BEGIN

# DECLARE and FETCH CURSOR should work in a read-only txn.
# DECLARE, FETCH, and CLOSE CURSOR should work in a read-only txn.
statement ok
DECLARE foo CURSOR FOR SELECT 1

statement ok
FETCH 1 foo

statement ok
CLOSE foo

statement ok
COMMIT

Expand Down
2 changes: 1 addition & 1 deletion pkg/sql/sem/tree/stmt.go
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ func (*CannedOptPlan) StatementTag() string { return "PREPARE AS OPT PLAN" }
func (*CloseCursor) StatementReturnType() StatementReturnType { return Ack }

// StatementType implements the Statement interface.
func (*CloseCursor) StatementType() StatementType { return TypeDCL }
func (*CloseCursor) StatementType() StatementType { return TypeDML }

// StatementTag returns a short string identifying the type of statement.
func (*CloseCursor) StatementTag() string { return "CLOSE" }
Expand Down

0 comments on commit c96e4a1

Please sign in to comment.