Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.3: sql: allow CLOSE CURSOR in read-only txns #137793

Merged
merged 1 commit into from
Dec 24, 2024
+5 −2
Merged

release-24.3: sql: allow CLOSE CURSOR in read-only txns #137793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pkg/sql/logictest/testdata/logic_test/txn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1520,13 +1520,16 @@ SET SESSION AUTHORIZATION DEFAULT
statement ok
BEGIN

# DECLARE and FETCH CURSOR should work in a read-only txn.
# DECLARE, FETCH, and CLOSE CURSOR should work in a read-only txn.
statement ok
DECLARE foo CURSOR FOR SELECT 1

statement ok
FETCH 1 foo

statement ok
CLOSE foo

statement ok
COMMIT

Expand Down
2 changes: 1 addition & 1 deletion pkg/sql/sem/tree/stmt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,7 @@ func (*CannedOptPlan) StatementTag() string { return "PREPARE AS OPT PLAN" }
func (*CloseCursor) StatementReturnType() StatementReturnType { return Ack }

// StatementType implements the Statement interface.
func (*CloseCursor) StatementType() StatementType { return TypeDCL }
func (*CloseCursor) StatementType() StatementType { return TypeDML }

// StatementTag returns a short string identifying the type of statement.
func (*CloseCursor) StatementTag() string { return "CLOSE" }
Expand Down