server: fix over redacted log lines

[aa-joshi]

Previosuly, few log lines were getting redacted assuming that it contains sensitive information. Support team was facing challenges during dignostics. To address this, this patch address few of the log lines which were overly redacted.

Epic: CRDB-37533
Part of: CRDB-44885
Release note: None

[blathers-crl]

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[cockroach-teamcity]

This change is 

[arjunmahishi]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @aa-joshi)

---

pkg/server/migration.go line 147 at r1 (raw file):

	}
	log.Infof(ctx, "active cluster version setting is now %s (up from %s)",
		redact.Safe(newCV.PrettyPrint()), redact.Safe(prevCV.PrettyPrint()))

I think we can directly pass newCV and prevCV without Safe or PrettyPrint. Because the underlying type implements SafeFormatter

It was getting redacted because PrettyPrint() returns string

[aa-joshi]

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @arjunmahishi)

---

pkg/server/migration.go line 147 at r1 (raw file):

Previously, arjunmahishi (Arjun Mahishi) wrote…

I think we can directly pass newCV and prevCV without Safe or PrettyPrint. Because the underlying type implements SafeFormatter

It was getting redacted because PrettyPrint() returns string

I believe we need to wrap in PrettyPrint because it has formatting logic based on v.IsFence()
ref:

cockroach/pkg/roachpb/version.go

Line 115 in ac3c5f2

func (v Version) PrettyPrint() string {

[arjunmahishi]

pkg/server/migration.go line 147 at r1 (raw file):

Previously, aa-joshi (Akshay Joshi) wrote…

I believe we need to wrap in PrettyPrint because it has formatting logic based on v.IsFence()
ref:

cockroach/pkg/roachpb/version.go

Line 115 in ac3c5f2

func (v Version) PrettyPrint() string {

Then I think we can change PrettyPrint and make it return redact.RedactableString
I think it's only being used for logging anyway.