Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: create a protobuf to hold stores #138051

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewbaptist
Copy link
Collaborator

@andrewbaptist andrewbaptist commented Dec 28, 2024

Summary of changes:

  • Create a struct configpb.Storage to represent all the "store related" pieces (mostly store config and WAL failover)
  • Move the encryption code into the configpb directory and delay "serialization" of the encryption options.
  • Remove all direct reads of the Stores from server.Config, instead use the new StorageConfig
  • Various cleanups to pass the configpb.Storage or configpb.Store in construction
  • Persisting the StorageConfig on each of the stores
  • Addition of a bootstrapConfig option which allows reading the config from either the OS disk or one of the existing disks.

WIP: This commit will be split up eventually.
Epic: none

Release note: None

Copy link

blathers-crl bot commented Dec 28, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andrewbaptist andrewbaptist force-pushed the 2024-12-18-store-config branch 5 times, most recently from e7603f5 to 38398e3 Compare January 10, 2025 20:43
Copy link

blathers-crl bot commented Jan 10, 2025

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@andrewbaptist andrewbaptist force-pushed the 2024-12-18-store-config branch from 38398e3 to 043755b Compare January 10, 2025 20:51
WIP: This commit will be split up eventually.
Epic: none

Release note: None
@andrewbaptist andrewbaptist force-pushed the 2024-12-18-store-config branch from 043755b to 98b6750 Compare January 10, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants