tests: get cdc_bench cursor at least 1s after table creation #138854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would get changefeed cursors from the current time after creating a table and before populating it. Due to the time being at a second granularity, it was possible that the cursor could be the same second that the table was created, which would lead to the table not appearing to be created yet. This change adds a 1s sleep before getting the cursor timestamp, to ensure that we don't encounter this scenario. Epic: None Fixes: cockroachdb#137758 Fixes: cockroachdb#135795 Release note: None
rharding6373
requested review from
a team and
wenyihu6
and removed request for
a team
|
This change is |
rharding6373
added
backport-23.2.x
|
TFTR! bors r=wenyihu6 |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #135795: branch-release-23.2, branch-release-24.1, branch-release-24.2, branch-release-24.3. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would get changefeed cursors from the current time after creating a table and before populating it. Due to the time being at a second granularity, it was possible that the cursor could be the same second that the table was created, which would lead to the table not appearing to be created yet.
This change adds a 1s sleep before getting the cursor timestamp, to ensure that we don't encounter this scenario.
Epic: None
Fixes: #137758
Fixes: #135795
Release note: None