Recommend disallow_full_table_scans session var

[rmloveland]

Fixes DOC-7875

[github-actions]

Files changed:

• src/current/v22.2/performance-best-practices-overview.md
• src/current/v23.1/performance-best-practices-overview.md
• src/current/v23.2/performance-best-practices-overview.md

[netlify]

✅ Deploy Preview for cockroachdb-api-docs canceled.

Name	Link
🔨 Latest commit	b73b402
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-api-docs/deploys/65cf80d36cdc6e0008330551

[netlify]

✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name	Link
🔨 Latest commit	b73b402
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/65cf80d3c1635e00086d79ba

[netlify]

✅ Netlify Preview

Name	Link
🔨 Latest commit	b73b402
🔍 Latest deploy log	https://app.netlify.com/sites/cockroachdb-docs/deploys/65cf80d3d3031c0007b81008
😎 Deploy Preview	https://deploy-preview-18265--cockroachdb-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[rafiss]

@dikshant do you have thoughts on whether we should recommend passing it in the connection string, versus recommending to configure the default value with ALTER ROLE ALL SET disallow_full_table_scans = true?

[rmloveland]

@dikshant do you have thoughts on whether we should recommend passing it in the connection string, versus recommending to configure the default value with ALTER ROLE ALL SET disallow_full_table_scans = true?

Thanks for looking @rafiss - I have pushed an update that makes this into a list of options instead:

1. per-cluster setting for all roles using ALTER ROLE as you mentioned
2. per-application setting on the connection string (less preferred since it's the number 2 option)

PTAL!

[rmloveland]

@rafiss and/or @dikshant - any objection to these latest changes? sorry to ping, I know I was away from it a bit myself

has a couple linked support issues from DOC-7875 so wanted to get it in

[dikshant]

LGTM! Thanks for adding this!

[rafiss]

i like describing both options. lgtm!

[dikshant]

Ah I missed this:

@dikshant do you have thoughts on whether we should recommend passing it in the connection string, versus recommending to configure the default value with ALTER ROLE ALL SET disallow_full_table_scans = true?

Yes let's have both and let customers pick whichever they prefer.