[DOC-8549] Document features that require finalization, backward-incompatible changes for v23.2 #18278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
fqazi
approved these changes
Feb 6, 2024
|
The line for #108190 looks good to me. |
maryliag
approved these changes
Feb 6, 2024
mdlinville
changed the title
sumeerbhola
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
AC changes are fine
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @arulajmani and @miraradeva)
|
This change is |
|
Thanks for the reviews! |
arulajmani
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Reviewable status:
src/current/v23.2/upgrade-cockroach-version.md line 142 at r2 (raw file):
When upgrading from {{ previous_version }} to {{ page.version.version }}, certain features and performance improvements will be enabled only after finalizing the upgrade, including but not limited to: - The coalescing of storage ranges for each table, index, or partition (collectively referred to as "schema objects") into a single range when individual schema objects are smaller than the default configured maximum range size (controlled using zone configs, specifically the `range_max_bytes parameter`). This change improves scalability with respect to the number of schema objects, since the underlying range count is no longer a potential performance bottleneck. After finalizing the upgrade to v23.2, you may observe a round of range merges and snapshot transfers. To disable this optimization, set the `spanconfig.storage_coalesce_adjacent.enabled` [cluster setting](https://www.cockroachlabs.com/docs/{{ page.version.version }}/cluster-settings) to `false`. Finalization is not required before disabling the optimization. See the [v23.1 release notes]({% link releases/v23.1.md %}) for `SHOW RANGES` for more details. [#102961][#102961]
nit: instead of saying "finalization is not required", it might be better worded as "this should be done before finalization"
… backward-incompatible changes previously removed
miraradeva
approved these changes
Feb 20, 2024
mikeCRL
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DOC-8549] Document features that require finalization, backward-incompatible changes for v23.2
The latter were mostly in place already, but I found a couple missing ones to add.
Source for features that require finalization: https://github.com/cockroachdb/cockroach/blame/release-23.2/pkg/clusterversion/cockroach_versions.go#L448-L506
HTML previews:
Backward-incompatible changes: releases/v23.2.md#v23-2-0-backward-incompatible-changes
Features that require finalization: src/current/v23.2/upgrade-cockroach-version.md#features-that-require-upgrade-finalization