Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC-10001] Add upgrade content for 24.1 pre-production previews #18427

Merged
merged 9 commits into from
Apr 17, 2024

Conversation

mdlinville
Copy link
Contributor

@mdlinville mdlinville commented Mar 28, 2024

Copy link

github-actions bot commented Mar 28, 2024

Files changed:

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 8bc3a04
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66201a41aefbd10008e4406f

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 8bc3a04
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66201a41c2343b0008e0ef15

Copy link

netlify bot commented Mar 28, 2024

Netlify Preview

Name Link
🔨 Latest commit 8bc3a04
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66201a41b94205000820c2c9
😎 Deploy Preview https://deploy-preview-18427--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/current/cockroachcloud/upgrade-to-v24.1.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/upgrade-to-v24.1.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/upgrade-to-v24.1.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/upgrade-to-v24.1.md Outdated Show resolved Hide resolved
@mdlinville mdlinville changed the title Add upgrade content for 24.1 pre-production previews [DOC-10001] Add upgrade content for 24.1 pre-production previews Mar 29, 2024
@mdlinville mdlinville requested review from rmloveland and removed request for mikeCRL April 8, 2024 23:50
@rmloveland
Copy link
Contributor

pre-review questions/comments:

  1. I guess upgrade-to-v24.1.md is mostly a copy of the previous version's file ? I'd like to know before I bother reading this whole huge file
  2. the render at https://deploy-preview-18427--cockroachdb-docs.netlify.app/docs/releases/cloud.html#april-2-2024 is pretty busted, it's in like h2 font
  3. the render at https://deploy-preview-18427--cockroachdb-docs.netlify.app/docs/cockroachcloud/upgrade-to-v23.2.html?filters=single-node#prepare-for-brief-unavailability is showing a double copy of the text you're editing on that page. Just a rendering bug?

@mdlinville
Copy link
Contributor Author

pre-review questions/comments:

  1. I guess upgrade-to-v24.1.md is mostly a copy of the previous version's file ? I'd like to know before I bother reading this whole huge file

I've reorganized the commit history so you can see exactly what's different from the v23.2 file now. Hope it helps.

  1. the render at https://deploy-preview-18427--cockroachdb-docs.netlify.app/docs/releases/cloud.html#april-2-2024 is pretty busted, it's in like h2 font

Fixed by removing some extra whitespace and a line that just had a - in it. I don't know why that caused this behavior.

  1. the render at https://deploy-preview-18427--cockroachdb-docs.netlify.app/docs/cockroachcloud/upgrade-to-v23.2.html?filters=single-node#prepare-for-brief-unavailability is showing a double copy of the text you're editing on that page. Just a rendering bug?

Nope, literally the same paragraph twice in a row. Fixed in both the v23.2 and v24.1 file, verified the bug was not in v23.1.

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a couple small suggestions / typos

src/current/cockroachcloud/upgrade-to-v24.1.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/upgrade-to-v24.1.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/upgrade-to-v24.1.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/upgrade-to-v24.1.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/upgrade-to-v24.1.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/upgrade-to-v24.1.md Outdated Show resolved Hide resolved
@mdlinville mdlinville enabled auto-merge (squash) April 17, 2024 18:52
@mdlinville mdlinville merged commit bd3f991 into main Apr 17, 2024
7 checks passed
@mdlinville mdlinville deleted the 24.1_ppp_upgrade branch April 17, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants