-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-9880 Update Observability docs for Cloud 2.0 - Resource Usage #18432
Conversation
…c.html. (2) Added filter-tabs/resource-usage.md include file. (3) Added resource-usage-basic.md, (a) copied from resource-usage.md, (b) removed references to standard, (c) removed standard sections. (4) In resource-usage.md, (a) removed references to basic, (c) removed basic sections.
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @Amruta-Ranade, I requested a review from you because we discussed this change weeks ago. I initially had updated the Resource Usage page with internal filters, but that caused problems (described in DOC-9880). This PR creates separate pages for Basic and Standard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for looking into it!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of suggestions for readability, as I had some trouble following the topic. These are on the Basic page but apply also to the Standard page.
src/current/_includes/v23.1/sidebar-data/cloud-deployments.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR!
src/current/_includes/v23.1/sidebar-data/cloud-deployments.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a couple remaining nits (they should apply to both docs if relevant).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR
Fixes DOC-9880
(1) In cloud-deployments.json, replaced link with resource-usage-basic.html.
(2) Added filter-tabs/resource-usage.md include file.
(3) Added resource-usage-basic.md, (a) copied from resource-usage.md, (b) removed references to standard, (c) removed standard sections.
(4) In resource-usage.md, (a) removed references to basic, (c) removed basic sections.
(5) incorporated Ryan’s feedback.