Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-9880 Update Observability docs for Cloud 2.0 - Resource Usage #18432

Merged
merged 6 commits into from
Apr 5, 2024

Conversation

florence-crl
Copy link
Contributor

@florence-crl florence-crl commented Mar 29, 2024

Fixes DOC-9880

(1) In cloud-deployments.json, replaced link with resource-usage-basic.html.
(2) Added filter-tabs/resource-usage.md include file.
(3) Added resource-usage-basic.md, (a) copied from resource-usage.md, (b) removed references to standard, (c) removed standard sections.
(4) In resource-usage.md, (a) removed references to basic, (c) removed basic sections.
(5) incorporated Ryan’s feedback.

…c.html.

(2) Added filter-tabs/resource-usage.md include file.

(3) Added resource-usage-basic.md, (a) copied from resource-usage.md, (b) removed references to standard, (c) removed standard sections.

(4) In resource-usage.md, (a) removed references to basic, (c) removed basic sections.
Copy link

github-actions bot commented Mar 29, 2024

Files changed:

Copy link

netlify bot commented Mar 29, 2024

Netlify Preview

Name Link
🔨 Latest commit 630c5e8
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6610434c560c960008e0110e
😎 Deploy Preview https://deploy-preview-18432--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@florence-crl
Copy link
Contributor Author

Hi @Amruta-Ranade, I requested a review from you because we discussed this change weeks ago. I initially had updated the Resource Usage page with internal filters, but that caused problems (described in DOC-9880). This PR creates separate pages for Basic and Standard.

Copy link
Contributor

@Amruta-Ranade Amruta-Ranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for looking into it!!

Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of suggestions for readability, as I had some trouble following the topic. These are on the Basic page but apply also to the Standard page.

src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
Copy link
Contributor

@taroface taroface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple remaining nits (they should apply to both docs if relevant).

src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR

src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
src/current/cockroachcloud/resource-usage-basic.md Outdated Show resolved Hide resolved
@florence-crl florence-crl merged commit 66868ed into cloud-2.0 Apr 5, 2024
4 checks passed
@florence-crl florence-crl deleted the DOC-9880 branch April 5, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants