Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC-8977] Add step to configure systemd to start CockroachDB automatically after a reboot #18439

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

mdlinville
Copy link
Contributor

@mdlinville mdlinville commented Apr 2, 2024

[DOC-8977] Add step to configure systemd to start CockroachDB automatically after a reboot

These includes touch several files each in each of v24.1, v23.2, and v23.1. For HTML previews, refer to #18439 (comment).

Copy link

github-actions bot commented Apr 2, 2024

Files changed:

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit 36c4206
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/660ee7c662f77700087a66b7

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit 36c4206
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/660ee7c62d480a0008d4605e

Copy link

netlify bot commented Apr 2, 2024

Netlify Preview

Name Link
🔨 Latest commit 36c4206
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/660ee7c6a6504e000863a967
😎 Deploy Preview https://deploy-preview-18439--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@jhatcher9999 jhatcher9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- systemd ignores manually-set limits
- Recommend testing carefully before setting the limit to infinity
Copy link
Contributor

@kathancox kathancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the production settings file, there is a render problem for two of the versions (see inline comments). Lmk when you want me to look again, thanks!

Copy link
Contributor

@kathancox kathancox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdlinville mdlinville enabled auto-merge (squash) April 4, 2024 17:48
@mdlinville mdlinville merged commit 4a3a85e into main Apr 4, 2024
7 checks passed
@mdlinville mdlinville deleted the DOC-8977 branch April 4, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants